-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attributeBinding
with properties not available in element prototype do not get set.
#10202
Comments
@mixonic - Can you confirm my summary (I may have the prop/attr thing backwards)? |
By the way, it looks like |
@wagenet there is normalization code that should have caught that. I believe the issue would be in |
It turns out this is not a new regression. It last worked in 1.7 where it rendered |
I was seeing the same issue in #10183 Is there anything I can do to help? |
There is no normalization for |
@kiwiupover - Off the top of my head I do not believe #10183 is related to this, but I'll try to dig around to confirm/deny. |
@rwjblue thanks. Thanks heaps for all you are doing. |
Looks like this is working now: http://emberjs.jsbin.com/xuyubejida/edit?html,js,output |
this behavior is now exactly what we want (and exactly the opposite of what it was.) |
We do a
attrName in element
check to see if a property exists for a given attribute, and if it does we set it as a prop, but if not we usesetAttribute
. In the case ofnovalidate
on<form>
elements, it is not a property, so we fallback tosetAttribute
(which leads to it not being added to the DOM).Demo: http://emberjs.jsbin.com/rwjblue/203/edit
The text was updated successfully, but these errors were encountered: