Check OPENSSL_NO_SM4 before using sm4 encryption #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
tabokie
approved these changes
Jul 13, 2022
Connor1996
approved these changes
Jul 14, 2022
Merged
|
@jiayang-zheng @Connor1996 @tabokie As cloud use tikv-6.1, should we cherry pick this fix to 6.4.tikv? |
|
We have #303 to cherry pick this fix to 6.4.tikv. I will ask @Connor1996 to take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some env, user installed openssl by
yum install, and the openssl software may complied withOPENSSL_NO_SM4flag, so although the version is >= 1.1.1, but we still could not use sm4 in that situation.Signed-off-by: Jarvis Zheng jiayang@hust.edu.cn