-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sm4 encryption (#295) #299
Add sm4 encryption (#295) #299
Conversation
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
Signed-off-by: Jarvis Zheng <jiayang@hust.edu.cn>
fd405dc
to
e6e7b40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @jiayang-zheng , I compiled under Centos 8 stream, met a compile problem: encryption/encryption.cc: In function 'rocksdb::Status rocksdb::encryption::NewAESCTRCipherStream(rocksdb::encryption::EncryptionMethod, const string&, const string&, std::unique_ptr<rocksdb::encryption::AESCTRCipherStream>*)':
encryption/encryption.cc:224:16: error: 'EVP_sm4_ctr' was not declared in this scope
cipher = EVP_sm4_ctr();
^~~~~~~~~~~
encryption/encryption.cc:224:16: note: suggested alternative: 'NID_sm4_ctr'
cipher = EVP_sm4_ctr();
^~~~~~~~~~~
NID_sm4_ctr The Would you please to see why? |
The
Fixed this issue in PR #302 #303 |
Origin PR #295