ms: change the default name of the microservice to lowercase #8551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: husharp <ihusharp@gmail.com>
ti-chi-bot
bot
added
release-note-none
17 tasks
lhy1024
approved these changes
Aug 21, 2024
rleungx
approved these changes
Aug 21, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
niubell
approved these changes
Aug 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, niubell, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8551 +/- ##
==========================================
- Coverage 77.64% 77.56% -0.08%
==========================================
Files 474 474
Lines 61877 61877
==========================================
- Hits 48043 47997 -46
- Misses 10306 10346 +40
- Partials 3528 3534 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8550
What is changed and how does it work?
we can use lowercase to be consistent with PD.
pd/server/config/config.go
Line 189 in 10cbdcf
./pd-server services tsoCheck List
Tests
Release note