PD: Add the name field to the startup parameters #18391
Conversation
Signed-off-by: husharp <ihusharp@gmail.com>
ti-chi-bot
bot
added
missing-translation-status
qiancai
added
for-release
ti-chi-bot
bot
removed
the
missing-translation-status
| ## `--name` <span class="version-mark">从 v8.3.0 版本开始引入</span> | ||
|
|
||
| + 当前 Scheduling 节点的名字。 | ||
| + 默认：`"Scheduling-hostname"` |
There was a problem hiding this comment.
Shall we use scheduling as the default name like pd?
There was a problem hiding this comment.
Based on the code here, do you mean modifying the code?
There was a problem hiding this comment.
lgtm. Maybe need to consider compatible because of data dir
https://github.com/tikv/pd/blob/f3602e31640a55b61a3b14fb3989c4a0742a2416/pkg/mcs/resourcemanager/server/config.go#L226-L234
There was a problem hiding this comment.
I prefer to remove the resource manager since it's useless for now.
There was a problem hiding this comment.
After that, we can use lowercase to be consistent with PD.
Not sure if this can be merged in 8.3.0 though :(
tikv/pd#8551
Signed-off-by: husharp <ihusharp@gmail.com>
|
@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
qiancai
added
translation/done
|
In response to a cherrypick label: new pull request created to branch |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?