Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix dr-auto-sync metics (#7975) #7982

Closed

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7975

What problem does this PR solve?

Issue Number: Close #7974

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image
image
image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.0 labels Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx March 26, 2024 07:00
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 26, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Merging #7982 (1c00ff7) into release-8.0 (92a303c) will decrease coverage by 0.08%.
Report is 1 commits behind head on release-8.0.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-8.0    #7982      +/-   ##
===============================================
- Coverage        73.50%   73.43%   -0.08%     
===============================================
  Files              436      436              
  Lines            48351    48354       +3     
===============================================
- Hits             35539    35507      -32     
- Misses            9751     9783      +32     
- Partials          3061     3064       +3     
Flag Coverage Δ
unittests 73.43% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@baurine
Copy link
Contributor

baurine commented Mar 28, 2024

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@baurine you're not a member of org tikv

@ti-chi-bot ti-chi-bot closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants