Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: fix dr-auto-sync metics #7975

Merged
merged 6 commits into from
Mar 26, 2024
Merged

metrics: fix dr-auto-sync metics #7975

merged 6 commits into from
Mar 26, 2024

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Mar 22, 2024

What problem does this PR solve?

Issue Number: Close #7974

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

image
image
image
image

Release note

None.

Signed-off-by: lhy1024 <admin@liudos.us>
Copy link
Contributor

ti-chi-bot bot commented Mar 22, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 22, 2024
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx March 22, 2024 09:57
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Merging #7975 (c163323) into master (39108f7) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head c163323 differs from pull request most recent head 0f99fb4. Consider uploading reports for the commit 0f99fb4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7975      +/-   ##
==========================================
- Coverage   73.58%   73.51%   -0.08%     
==========================================
  Files         436      436              
  Lines       48461    48464       +3     
==========================================
- Hits        35660    35626      -34     
- Misses       9743     9777      +34     
- Partials     3058     3061       +3     
Flag Coverage Δ
unittests 73.51% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@HuSharp HuSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you paste the metric picture?

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2024
@HuSharp HuSharp requested a review from JmPotato March 25, 2024 09:09
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: lhy1024 <admin@liudos.us>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 26, 2024
@lhy1024 lhy1024 added the needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. label Mar 26, 2024
@lhy1024
Copy link
Contributor Author

lhy1024 commented Mar 26, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

This pull request has been accepted and is ready to merge.

Commit hash: c163323

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 26, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 26, 2024

@lhy1024: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 29a4a2a into tikv:master Mar 26, 2024
22 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #7982.

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-8.0 The PR needs to cherry pick to release-8.0 branch. label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(dr-auto-sync)no data in dr-auto-sync state in metric after set to dr-auto-sync mode
4 participants