Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs/tso: add log to show the progress of group cleaning up #6971

Merged
merged 2 commits into from
Aug 22, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #6589.

What is changed and how does it work?

Add log to show the progress of group cleaning up.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato added component/tso Timestamp Oracle. component/keyspace Key space. labels Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bufferflies
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2023
@JmPotato JmPotato added the component/mcs Microservice. label Aug 22, 2023
Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested a review from lhy1024 August 22, 2023 04:16
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #6971 (e3817cf) into master (346e771) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6971      +/-   ##
==========================================
- Coverage   74.36%   74.35%   -0.01%     
==========================================
  Files         427      427              
  Lines       45334    45351      +17     
==========================================
+ Hits        33711    33723      +12     
- Misses       8659     8667       +8     
+ Partials     2964     2961       -3     
Flag Coverage Δ
unittests 74.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 22, 2023
@JmPotato
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

This pull request has been accepted and is ready to merge.

Commit hash: e3817cf

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot merged commit 497c942 into tikv:master Aug 22, 2023
23 checks passed
@JmPotato JmPotato deleted the group_cleaner_log branch August 22, 2023 07:12
rleungx pushed a commit to rleungx/pd that referenced this pull request Dec 1, 2023
* pd-ctl: make `TestShowKeyspaceGroupPrimary` stable (tikv#6903)

close tikv#6783

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

* pd-ctl: fix keyspace group split hang when pd is in pd-mode (tikv#6907)

close tikv#6906

Signed-off-by: lhy1024 <admin@liudos.us>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: lhy1024 <admin@liudos.us>

* mcs/tso: add log to show the progress of group cleaning up (tikv#6971)

ref tikv#6589

Add log to show the progress of group cleaning up.

Signed-off-by: JmPotato <ghzpotato@gmail.com>

* etcdutil, leadership: use RequestProgress in watch loop (tikv#6961)

close tikv#6889

Signed-off-by: lhy1024 <admin@liudos.us>

---------

Signed-off-by: lhy1024 <admin@liudos.us>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/keyspace Key space. component/mcs Microservice. component/tso Timestamp Oracle. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants