server: add max one peer count balance support. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // only need to add new peer and remove leader peer. | ||
| meta := cluster.getMeta() | ||
| if meta.GetMaxPeerCount() == 1 { | ||
| addPeerOperator := newAddPeerOperator(regionID, newPeer) |
There was a problem hiding this comment.
When the new peer is added, will pd remove one peer automatically?
|
LGTM |
1 similar comment
|
LGTM |
rleungx
pushed a commit
to rleungx/pd
that referenced
this pull request
Dec 1, 2023
* pd-ctl: make `TestShowKeyspaceGroupPrimary` stable (tikv#6903) close tikv#6783 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * pd-ctl: fix keyspace group split hang when pd is in pd-mode (tikv#6907) close tikv#6906 Signed-off-by: lhy1024 <admin@liudos.us> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: lhy1024 <admin@liudos.us> * mcs/tso: add log to show the progress of group cleaning up (tikv#6971) ref tikv#6589 Add log to show the progress of group cleaning up. Signed-off-by: JmPotato <ghzpotato@gmail.com> * etcdutil, leadership: use RequestProgress in watch loop (tikv#6961) close tikv#6889 Signed-off-by: lhy1024 <admin@liudos.us> --------- Signed-off-by: lhy1024 <admin@liudos.us> Signed-off-by: JmPotato <ghzpotato@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.