Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: return GetMembers error as a gRPC error to let TiKV retry #5410

Closed
wants to merge 1 commit into from

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 8, 2022

Signed-off-by: JmPotato ghzpotato@gmail.com

What problem does this PR solve?

Issue Number: Ref #5309. Close #5409.

What is changed and how does it work?

Return GetMembers error as a gRPC error to let TiKV retry.

Check List

Tests

  • Unit test
  • Integration test

Related changes

#5310.

Release note

None.

Signed-off-by: JmPotato <ghzpotato@gmail.com>
@JmPotato JmPotato requested review from nolouch and Connor1996 August 8, 2022 05:52
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 8, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Connor1996

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Aug 8, 2022
@JmPotato
Copy link
Member Author

JmPotato commented Aug 8, 2022

@HuSharp PTAL.

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #5410 (a9f7a06) into master (99e38eb) will increase coverage by 0.13%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #5410      +/-   ##
==========================================
+ Coverage   75.58%   75.72%   +0.13%     
==========================================
  Files         312      312              
  Lines       31061    31065       +4     
==========================================
+ Hits        23479    23525      +46     
+ Misses       5572     5538      -34     
+ Partials     2010     2002       -8     
Flag Coverage Δ
unittests 75.72% <77.77%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/tso/global_allocator.go 61.25% <ø> (ø)
server/grpc_service.go 49.14% <50.00%> (-0.26%) ⬇️
server/schedule/filter/filters.go 91.64% <79.41%> (-0.43%) ⬇️
server/id/id.go 80.76% <0.00%> (-3.85%) ⬇️
pkg/metricutil/metricutil.go 89.65% <0.00%> (-3.45%) ⬇️
server/storage/endpoint/meta.go 63.63% <0.00%> (-2.28%) ⬇️
client/base_client.go 80.86% <0.00%> (-1.44%) ⬇️
server/region_syncer/server.go 86.26% <0.00%> (-1.10%) ⬇️
server/server.go 74.56% <0.00%> (-1.06%) ⬇️
server/cluster/cluster.go 83.61% <0.00%> (-0.37%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 8, 2022
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better walk through the other spots to make sure no wrong return. I check AllocID and BootStrap, they seems okay.

@JmPotato
Copy link
Member Author

JmPotato commented Aug 8, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2022
@JmPotato
Copy link
Member Author

JmPotato commented Aug 8, 2022

Close since the wrong fix.

@JmPotato JmPotato closed this Aug 8, 2022
@JmPotato JmPotato deleted the retrun_grpc_error branch August 8, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GetMembers error should return as a gRPC error to let TiKV retry
3 participants