-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: return GetMembers error as a gRPC error to let TiKV retry #5410
Conversation
Signed-off-by: JmPotato <ghzpotato@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@HuSharp PTAL. |
Codecov Report
@@ Coverage Diff @@
## master #5410 +/- ##
==========================================
+ Coverage 75.58% 75.72% +0.13%
==========================================
Files 312 312
Lines 31061 31065 +4
==========================================
+ Hits 23479 23525 +46
+ Misses 5572 5538 -34
+ Partials 2010 2002 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better walk through the other spots to make sure no wrong return. I check AllocID
and BootStrap
, they seems okay.
/hold |
Close since the wrong fix. |
Signed-off-by: JmPotato ghzpotato@gmail.com
What problem does this PR solve?
Issue Number: Ref #5309. Close #5409.
What is changed and how does it work?
Check List
Tests
Related changes
#5310.
Release note