Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetMembers error should return as a gRPC error to let TiKV retry #5409

Closed
JmPotato opened this issue Aug 8, 2022 · 1 comment
Closed

GetMembers error should return as a gRPC error to let TiKV retry #5409

JmPotato opened this issue Aug 8, 2022 · 1 comment
Labels
affects-6.2 severity/moderate type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

JmPotato commented Aug 8, 2022

Bug Report

Details: tikv/tikv#13124.

We should return the gRPC error in some cases to let TiKV retry on the next PD member.

Ref: https://github.com/tikv/pd/pull/5310/files#diff-eb404b45d0a569b05f58f4e4bf2b42b32150be75ec2ed72f86330c4b5d739eabR108
@JmPotato JmPotato added type/bug The issue is confirmed as a bug. affects-6.2 labels Aug 8, 2022
@JmPotato JmPotato changed the title GetMember error should return as a gRPC error to let TiKV retry GetMembers error should return as a gRPC error to let TiKV retry Aug 8, 2022
@JmPotato JmPotato mentioned this issue Aug 8, 2022
Closed
@JmPotato
Copy link
Member Author

JmPotato commented Aug 8, 2022

Close since duplicated with #5411.

@JmPotato JmPotato closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.2 severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: return GetMembers error as a gRPC error to let TiKV retry JmPotato/pd
1 participant
@JmPotato