-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics, cluster: fix miss heartbeat update #3559
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
@@ -548,6 +548,11 @@ func (c *RaftCluster) processRegionHeartbeat(region *core.RegionInfo) error { | |||
writeItems := c.CheckWriteStatus(region) | |||
readItems := c.CheckReadStatus(region) | |||
c.RUnlock() | |||
c.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this lock will become the heartbeat bottleneck.
Codecov Report
@@ Coverage Diff @@
## master #3559 +/- ##
==========================================
+ Coverage 74.66% 74.75% +0.09%
==========================================
Files 245 245
Lines 24090 24111 +21
==========================================
+ Hits 17986 18024 +38
+ Misses 4495 4485 -10
+ Partials 1609 1602 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
Close #3199 and close #3558
Check List
Tests
Release note