Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The statistics of miss-peer is not accurate sometimes #3199

Open
rleungx opened this issue Nov 23, 2020 · 1 comment · May be fixed by #3901
Open

The statistics of miss-peer is not accurate sometimes #3199

rleungx opened this issue Nov 23, 2020 · 1 comment · May be fixed by #3901
Assignees
Labels
severity/moderate type/bug The issue is confirmed as a bug.

Comments

@rleungx
Copy link
Member

rleungx commented Nov 23, 2020

Bug Report

What did you do?

Use pd-ctl to set the max-replicas to 2 with a cluster having 15w regions. And after all extra peers are removed, change back the max-replicas to 3.

Screen Shot 2020-11-23 at 10 44 24 AM

As you can see from the above screenshot, after changing back the parameters, there should be a lot of missing peers. But actually, there are a few missing peers.

What version of PD are you using (pd-server -V)?

master

@rleungx rleungx added the type/bug The issue is confirmed as a bug. label Nov 23, 2020
@rleungx rleungx linked a pull request Nov 24, 2021 that will close this issue
rleungx added a commit to rleungx/pd that referenced this issue Nov 24, 2021
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Nov 29, 2021
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 1, 2021
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 23, 2021
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Dec 28, 2021
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx added a commit to rleungx/pd that referenced this issue Jan 21, 2022
Close tikv#3286, close tikv#3558, close tikv#3199

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
Copy link
Member Author

rleungx commented Dec 25, 2023

There is another issue: After we change the placement rule to add more peers, there are some missed peers which are always exist, but the log shows the region doesn't have missed peers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
4 participants