server: fix the valid scheduler was deleted when start coordinator #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
added
type/bug
Connor1996
reviewed
May 3, 2018
server/coordinator.go
Outdated
| @@ -206,6 +206,9 @@ func (c *coordinator) run() { | |||
| scheduleCfg := c.cluster.opt.load() | |||
| for _, schedulerCfg := range scheduleCfg.Schedulers { | |||
| if schedulerCfg.Disable { | |||
| scheduleCfg.Schedulers[k] = schedulerCfg | |||
| k++ | |||
| log.Warning("skip create ", schedulerCfg.Type) | |||
There was a problem hiding this comment.
I don't think it should be in warning level
|
/ok-to-test |
|
/run-all-tests |
disksing
pushed a commit
to oh-my-tidb/pd
that referenced
this pull request
May 7, 2018
…ikv#1045) * server: fix the valid scheduler was deleted when start coordinator
disksing
added a commit
that referenced
this pull request
May 8, 2018
* server: skip check a region if there is already a pending operator. (#1029) * pdctl, api, schedule: pdctl supports scatter region. (#1028) * add change log (#1024) * scheduler: hot write scheduler randomly select the balance strategy (#1034) * *: new store region score function for balance (#1014) * core: adjust capacity to fit for more cases (#1035) * check config validation (#1036) * *: add metrics for hotspot cache (#1027) * Refine install instructions. (#1041) These extra steps can help new users who are perhaps not quite so familiar with Go setup and conventions. * *: add change log for 2.0 GA (#1038) * *: add change log for ga. * scheduler: adjust metrics (#1042) * fix parse error of config.toml (#1043) * server: resign pd leader when it is not same as etcd leader. (#1039) * server: fix the valid scheduler was deleted when start coordinator (#1045) * server: fix the valid scheduler was deleted when start coordinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if disable a default scheduler and restart PD, it will delete the scheduler whether it is valid or not. and then restart PD, it will create the default scheduler again because of it think that is a newly added default scheduler.