Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: resign pd leader when it is not same as etcd leader. #1039

Merged
merged 7 commits into from
May 2, 2018

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Apr 27, 2018

When leader priority is updated on the fly, etcd leader is transferred to the one has the highest priority, while PD leader is not changed. This PR makes sure PD leader switches the same instance.

@disksing disksing requested a review from nolouch April 27, 2018 03:20
Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siddontang
Copy link
Contributor

Please add a description

@nolouch
Copy link
Contributor

nolouch commented Apr 27, 2018

ci always failed.

@disksing disksing added the type/bug The issue is confirmed as a bug. label May 2, 2018
@disksing
Copy link
Contributor Author

disksing commented May 2, 2018

/run-all-tests

Copy link
Contributor

@nolouch nolouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing added status/tests-passed The PR has passed all tests. needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. labels May 2, 2018
@disksing
Copy link
Contributor Author

disksing commented May 2, 2018

PTAL @Connor1996

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@disksing disksing merged commit 00a31f0 into tikv:master May 2, 2018
@disksing disksing deleted the leader branch May 2, 2018 12:51
disksing added a commit to oh-my-tidb/pd that referenced this pull request May 7, 2018
disksing added a commit that referenced this pull request May 8, 2018
* server: skip check a region if there is already a pending operator. (#1029)

* pdctl, api, schedule: pdctl supports scatter region. (#1028)

* add change log (#1024)

* scheduler: hot write scheduler randomly select the balance strategy (#1034)

* *: new store region score function for balance (#1014)

* core: adjust capacity to fit for more cases (#1035)

* check config validation (#1036)

* *: add metrics for hotspot cache (#1027)

* Refine install instructions. (#1041)

These extra steps can help new users who are perhaps not quite so familiar with Go setup and conventions.

* *: add change log for 2.0 GA (#1038)

* *: add change log for ga.

* scheduler: adjust metrics (#1042)

* fix parse error of config.toml (#1043)

* server: resign pd leader when it is not same as etcd leader. (#1039)

* server: fix the valid scheduler was deleted when start coordinator (#1045)

* server: fix the valid scheduler was deleted when start coordinator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.0 The PR needs to cherry pick to release-2.0 branch. status/tests-passed The PR has passed all tests. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants