Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS-1592] - Changes WAF from Coraza back to ModSecurity. #3078

Closed

Conversation

mikestephen
Copy link
Contributor

Description

This PR reverts the PR which changed from using ModSecurity to Coraza as the WAF engine. This is being done because WAF with Coraza doesn't currently work and is holding up Enterprise v3.19-EP1.

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

@danudey danudey modified the milestones: v1.33.0, v1.33.1, v1.34.0 Jan 31, 2024
@radTuti radTuti modified the milestones: v1.34.0, v1.34.1 May 11, 2024
@danudey danudey modified the milestones: v1.34.1, v1.34.2 Jun 21, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mike Stephen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@tmjd
Copy link
Member

tmjd commented Jun 28, 2024

This is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants