-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update CoreRuleset payload for dikastes' new WAF engine #2991
update CoreRuleset payload for dikastes' new WAF engine #2991
Conversation
- now embedded, no need to rely on go:generate - reorganise how we do the customisations, put all our custom CRS behaviour in its own tigera.conf file
ModSecurityRulesetConfigMapName = "modsecurity-ruleset" | ||
ModSecurityRulesetHashAnnotation = "hash.operator.tigera.io/modsecurity-ruleset" | ||
CalicoLogsVolumeName = "var-log-calico" | ||
CalicologsVolumePath = "/var/log/calico" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only used within this file, should probably be private
To be honest, I suspect that is true of many of these variables, but since we're touching this one we should make it private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - one minor nit about variables being public.
Description
Now that we're changing the WAF engine in Dikastes from Modsecurity to Coraza, this PR provides mainly two changes that ties into that changel:
Here is a more detailed breakdown on the changes in this PR
tigera.conf
fileDepends on https://github.com/tigera/calico-private/pull/6862 but that PR also depends on this one.
For PR author
make gen-files
make gen-versions
For PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bug
if this is a bugfix.kind/enhancement
if this is a a new feature.enterprise
if this PR applies to Calico Enterprise only.