Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH #calico-8364] Update calicoctl binary command #1220

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

coutinhop
Copy link
Member

@coutinhop coutinhop commented Dec 21, 2023

Remove the leading '/' from the 'calicoctl' command when running it as a pod, due to the calicoctl container being updated in projectcalico/calico#8364

Product Version(s):

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

Remove the leading '/' from the 'calicoctl' command when running it as a
pod, due to the calicoctl container being updated in
projectcalico/calico#8364
@coutinhop coutinhop requested a review from a team as a code owner December 21, 2023 16:52
Copy link

netlify bot commented Dec 21, 2023

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit a3a9ba9
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65846d6af9d1630008fe2a8e
😎 Deploy Preview https://deploy-preview-1220--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 37 (🔴 down 11 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 21, 2023

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit a3a9ba9
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65846d6a866feb0008908477
😎 Deploy Preview https://deploy-preview-1220--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58 (🔴 down 13 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bmckercher123 bmckercher123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmckercher123 bmckercher123 merged commit 78007dd into tigera:main Dec 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants