Move calicoctl binary to standard executable search path #8364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
|
Tested the following command manually and it gives the expected output. $ docker run --rm --entrypoint calicoctl --name calicoctl calico/ctl:latest version
Client Version: v3.28.0-0.dev-251-ge83ae8169391-dirty
Git commit: e83ae8169
Unable to detect installed Calico versionand also this. $ docker run --rm --name calicoctl calico/ctl:latest version
Client Version: v3.28.0-0.dev-251-ge83ae8169391-dirty
Git commit: e83ae8169
Unable to detect installed Calico version |
coutinhop
previously approved these changes
Dec 20, 2023
hjiawei
force-pushed
the
calicoctl-path
branch
from
7a69d34 to
895fe83
Compare
hjiawei
dismissed
coutinhop’s stale review
New changes added with more UT/FVs to run
hjiawei
force-pushed
the
calicoctl-path
branch
from
895fe83 to
34da06b
Compare
coutinhop
reviewed
Dec 20, 2023
hjiawei
force-pushed
the
calicoctl-path
branch
from
34da06b to
54f32e9
Compare
This change moves calicoctl binary to the standard executable search path so that it can be found without using an absolute path.
hjiawei
force-pushed
the
calicoctl-path
branch
from
54f32e9 to
e42b962
Compare
coutinhop
approved these changes
Dec 21, 2023
3 tasks
coutinhop
added a commit
to coutinhop/tigera-docs
that referenced
this pull request
Dec 21, 2023
Remove the leading '/' from the 'calicoctl' command when running it as a pod, due to the calicoctl container being updated in projectcalico/calico#8364
5 tasks
bmckercher123
pushed a commit
to tigera/docs
that referenced
this pull request
Dec 21, 2023
Remove the leading '/' from the 'calicoctl' command when running it as a pod, due to the calicoctl container being updated in projectcalico/calico#8364
caseydavenport
added
docs-not-required
marvin-tigera
removed
release-note-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change moves calicoctl binary to the standard executable search path so that it can be found without using an absolute path.
Related issues/PRs
Alternative fix for #8362.
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.