Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first draft proposal implementation for handling invalid lanelets #76

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Mar 3, 2023

Related Links

Discussion

Issue

Relevant PRs

Notes for reviewers

For compiling and testing this PR, all PRs in related links section need to be taken into consideration.

Notes for reviewers

For compiling and testing this PR, all PRs in related links section need to be taken into consideration.

Merge sequence can be found here

Description

This PR is one of group of PRs for providing a solution for the idea discussed here.

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@isamu-takagi
Copy link
Contributor

I think a name that means it is not included in ODD would be better. I could not imagine the background of the discussion from the name INVALID_LANELET.

@ahmeddesokyebrahim
Copy link
Contributor Author

I think a name that means it is not included in ODD would be better. I could not imagine the background of the discussion from the name INVALID_LANELET.

Thanks Mr @isamu-takagi for your comment.

When I presented this idea first time at ASWG, I was proposing it as invalid or out of ODD as mentioned in the discussion. During the meeting some colleagues commented that the naming of out of ODD is very wide and may include a lot of meanings. ODD may include road types, driving scenario types, speed limits, weather condition, .... any many other examples.

That is went for naming with invalid rather than out of ODD .

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/tier4_autoware_msgs/3308-feat-handle-invalid-lanelets branch from 6ceaaa8 to 0e9cfe4 Compare March 23, 2023 11:47
@isamu-takagi
Copy link
Contributor

That is went for naming with invalid rather than out of ODD .

@ahmeddesokyebrahim
I got it. It's fine If agreed in the ASWG, but personally I get the impression that it's detected an error in the lanelet map definition.

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/tier4_autoware_msgs/3308-feat-handle-invalid-lanelets branch from 4901cd5 to 00620a0 Compare April 12, 2023 11:14
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/tier4_autoware_msgs/3308-feat-handle-invalid-lanelets branch from 00620a0 to 0e8e76d Compare April 25, 2023 17:21
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/tier4_autoware_msgs/3308-feat-handle-invalid-lanelets branch from 0e8e76d to 5d10e87 Compare May 5, 2023 09:17
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r enabled auto-merge (squash) May 11, 2023 07:58
@mitsudome-r mitsudome-r merged commit f952fbc into tier4:tier4/universe May 11, 2023
satoshi-ota pushed a commit that referenced this pull request May 25, 2023
…ts (#76)

* feat: first draft proposal implementation for handling invalid lanelets

* feat: handling invalid lanelet in RTC 

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>

* feat: changing module name from invalid_lanelet to no_drivable_lane

---------

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants