-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: first draft proposal implementation for handling invalid lanelets #76
feat: first draft proposal implementation for handling invalid lanelets #76
Conversation
I think a name that means it is not included in ODD would be better. I could not imagine the background of the discussion from the name INVALID_LANELET. |
Thanks Mr @isamu-takagi for your comment. When I presented this idea first time at ASWG, I was proposing it as That is went for naming with |
6ceaaa8
to
0e9cfe4
Compare
@ahmeddesokyebrahim |
4901cd5
to
00620a0
Compare
00620a0
to
0e8e76d
Compare
0e8e76d
to
5d10e87
Compare
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ts (#76) * feat: first draft proposal implementation for handling invalid lanelets * feat: handling invalid lanelet in RTC Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com> * feat: changing module name from invalid_lanelet to no_drivable_lane --------- Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Related Links
Discussion
Issue
Relevant PRs
tier4/tier4_ad_api_adaptorNotes for reviewers
For compiling and testing this PR, all PRs in related links section need to be taken into consideration.
Notes for reviewers
For compiling and testing this PR, all PRs in related links section need to be taken into consideration.
❗ Merge sequence can be found here ❗
Description
This PR is one of group of PRs for providing a solution for the idea discussed here.
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks