Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nebula): add autoware point type publishers #27

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Conversation

amc-nu
Copy link
Contributor

@amc-nu amc-nu commented Jun 7, 2023

PR Type

  • New Feature

Related Links

https://tier4.atlassian.net/browse/RT1-929?atlOrigin=eyJpIjoiNTg4MThjNWFlMzE1NDM1YjgyYTY2NjE4YWUzMDJhZWYiLCJwIjoiaiJ9

Description

ROS Wrappers (Hesai, Velodyne) now advertise and publish (if subscribed) three sensor_msgs::msgs::PointCloud2 types:

  • New point type (PointXYZIRCAEDT)
  • Autoware extended type (PointXYZIRADT)
  • Autoware base type (PointXYZIR)

Review Procedure

Verify point cloud published matches the point cloud type indicated above

  • /XXX_points (PointXYZIRCAEDT)
  • /aw_points_ex Autoware extended type (PointXYZIRADT)
  • /aw_points Autoware base type (PointXYZIR)

amc-nu and others added 3 commits June 7, 2023 12:30
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
@drwnz drwnz self-requested a review June 7, 2023 04:06
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit 454e7bf into main Jun 7, 2023
@amc-nu amc-nu deleted the autoware_type branch June 15, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants