[Draft] Pandar AT128 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add colcon build env. (base code is 0624e) * move some hpp files, add src folder in livox driver * trivial modification * Update README.md * remove unneccesary files * remove unneccesary header * move third-party source files * update code(20210630) * Delete different test files. * README.md add "4. running" * README crlf * HwInterface/udp_socket.hpp * modify for ros2 run error * Update README.md * accumulate_count * time_stamp * struct LivoxPointXyzrtl packed * GetEchoNumPerPoint() * cloud.width 24000 * time_base -> time_stamp * code fix * cloud.width update * code fix * code fix * StreamStart retry 30sec * code fix * rviz2 * fix format * <br> * format ros2wrapper * frame_id * frame_id * Update README.md * Update README.md * discussion_r664993039 * typo typo brief and only English in the comments. and LivoxDataCallback delete * PI -> M_PI * Revert "PI -> M_PI" This reverts commit c54bbe3b3c1954f82247d38570bdf71a3ddf38b6. * PI -> M_PI 2nd * thread pointer -> shared_ptr * modify CMakelists.txt and package.xml to using ament_cmake_auto * README.md * default node name * add composable node (#4) * add composable node * fix conflicts * fix exec node * change sensor name fix to variable * fix can use ros2_wrapper_main.cpp * README.md * default node name * change namespace * add namespace to topic names Co-authored-by: mitui.hide <h-mitsui@esol.co.jp> * package.xml maintainer and README.md * #discussion_r666683800 * #discussion_r666712110 * #discussion_r665125337 * #discussion_r664995104 * #discussion_r666078326 * #discussion_r665121366 * #discussion_r665121366 Expansion * typedef enum -> enum * typedef enum -> enum * #discussion_r665121708 * #discussion_r665124279 * #discussion_r664995791 * typo #discussion_r670300391 * #discussion_r664987903 * Revert "#discussion_r664987903" This reverts commit 97d78e64c13e5bb59b98bd1f17f1bfd527384852. * #discussion_r664987903 * #discussion_r664988302 * #discussion_r664989270 * #discussion_r664989004 * CMakeList.txt remove(-g -O0) * smart_pointers. #issuecomment-878771481 Co-authored-by: mitui.hide <h-mitsui@esol.co.jp> Co-authored-by: v-nagai7872@esol.co.jp <v-nagai7872@esol.co.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
* add colcon build env. (base code is 0624e) * move some hpp files, add src folder in livox driver * trivial modification * Update README.md * remove unneccesary files * remove unneccesary header * move third-party source files * update code(20210630) * Delete different test files. * README.md add "4. running" * README crlf * HwInterface/udp_socket.hpp * modify for ros2 run error * Update README.md * accumulate_count * time_stamp * struct LivoxPointXyzrtl packed * GetEchoNumPerPoint() * cloud.width 24000 * time_base -> time_stamp * code fix * cloud.width update * code fix * code fix * StreamStart retry 30sec * code fix * rviz2 * fix format * <br> * format ros2wrapper * frame_id * frame_id * Update README.md * Update README.md * discussion_r664993039 * typo typo brief and only English in the comments. and LivoxDataCallback delete * PI -> M_PI * Revert "PI -> M_PI" This reverts commit c54bbe3b3c1954f82247d38570bdf71a3ddf38b6. * PI -> M_PI 2nd * thread pointer -> shared_ptr * modify CMakelists.txt and package.xml to using ament_cmake_auto * README.md * default node name * add composable node (#4) * add composable node * fix conflicts * fix exec node * change sensor name fix to variable * fix can use ros2_wrapper_main.cpp * README.md * default node name * change namespace * add namespace to topic names Co-authored-by: mitui.hide <h-mitsui@esol.co.jp> * package.xml maintainer and README.md * #discussion_r666683800 * #discussion_r666712110 * #discussion_r665125337 * #discussion_r664995104 * #discussion_r666078326 * #discussion_r665121366 * #discussion_r665121366 Expansion * typedef enum -> enum * typedef enum -> enum * #discussion_r665121708 * #discussion_r665124279 * #discussion_r664995791 * esol_ReviewNo6 * esol_ReviewNo26 * esol_ReviewNo24 * Revert "esol_ReviewNo24" This reverts commit 0e8f33341186d6fa4a905de45c8f9aa28b8d29cb. * Revert "esol_ReviewNo24" This reverts commit 0e8f33341186d6fa4a905de45c8f9aa28b8d29cb. * esol_ReviewNo24 * esol_ReviewNo27 * esol_ReviewNo17 * format * esol_ReviewNo21 * develop #1 6bae863876bfda52db848ed31e415a3b16a0b6a8 * tab -> space * develop marge * CMakeLists.txt remove(-g -O0) * T4PUB-358 1st * format and bug-fix * 5#discussion_r677475332 * Add comment semaphore_ * 5#discussion_r678802453 Co-authored-by: mitui.hide <h-mitsui@esol.co.jp> Co-authored-by: v-nagai7872@esol.co.jp <v-nagai7872@esol.co.jp> Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com> Co-authored-by: h-mitsui-esol <57085544+h-mitsui-esol@users.noreply.github.com>
* Refactor 1st * pull/6#discussion_r681704754 * pull/6#discussion_r682172984 * pull/6#discussion_r681705368 * pull/6#discussion_r680921593 and pull/6#discussion_r680922194 * pull/6#discussion_r681711654 * 6#discussion_r682170555
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
* Refactor 1st * pull/6#discussion_r681704754 * pull/6#discussion_r682172984 * pull/6#discussion_r681705368 * pull/6#discussion_r680921593 and pull/6#discussion_r680922194 * pull/6#discussion_r681711654 * 6#discussion_r682170555 * livox_driver utest 1st * T4PUB-437 bug fix. * Fix merge failure 3371552e395f1817adb3a32ea9f95360d72019f8 * pull/9#discussion_r689167375 and pull/9#discussion_r689204716
* Livox Diagnostics. Initial non working commit Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * clang. add tier4 format Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * gitignore. Add Tier4 ignore file Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * wip Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * wip 2 Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * code adaptations to new main branch Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * wip 3 get device status from sensor Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * adaptations for diagnostics from eth packet Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * RosWrapper. parse and report Diagnostics Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * lidar_driver. fix getcommandid switch Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * ros2_driver_wrapper. fix switch indent Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * git workflow. test CI token Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * livox_command. Remove unused CommandPushAbnormalState struct Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * add fallthroughts Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * apply t4 formatting Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * livox_diagnostics. remove unnecessary code for boolean vars Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * ros2_driver_wrapper. clarify level comparison with enum Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * livox_diagnostics. remove unncessary comma at the end of enum Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * ros2_driver_wrapper. group diagnostics members Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * gitignore. remove aw related entries Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * ros2_driver_wrapper. simplify ros diagnostics string Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * revert fallthroughs on switch Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * replace shift logic for bit fields Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * add private keyword to clarify Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * separate diagnostics, remove static definition Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * add missing StatusCodeToLivoxMotorStatus Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * Separate diagnostics to multiple reports Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * update status from sensor Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * wrapper. remove the namespace from the diagnostic task Signed-off-by: amc-nu <abrahammonrroy@yahoo.com> * ros2_wrapper. remove unncessary lidar_identifier Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: amc-nu <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com>
* Testing VLS128 * transport_drivers. api Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * 312cd76's forgotten items... * build_depends. switch to boost from asio on transport_drivers Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> --------- Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> Co-authored-by: Abraham Cano <abrahammonrroy@yahoo.com>
Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 2.22.0 to 2.24.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v2.22.0...v2.24.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.3.0...v3.4.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Documentation. Initial MkDocs+MkDoxy Generator Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * github actions. enable mkdocs Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * github actions. documentation add sudo Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * github actions. documentation add pip Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * github actions. documentation add pip Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * github actions. documentation add pip Signed-off-by: amc-nu <abraham.monrroy@gmail.com> --------- Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v2...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 2.24.0 to 2.25.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v2.24.0...v2.25.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 2.25.0 to 2.26.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v2.25.0...v2.26.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 2.26.0 to 2.26.1. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v2.26.0...v2.26.1) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add setup_sensor flag for hw drivers * point timestamp, point.return_type * Support QT128 * qt to qt64 * pandar128e4x. change point type Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * pandar128e4x. clean up Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * pandar128. reserve data Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * signed to unsigned, debug * fixed * QT128 Dual * QT128 timestamp fixed * Repository restructure Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * config. restructure files Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * driver. restructure Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * offline_sample. require nebula Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Separate Nebula into multiple libraries Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Apply clang format Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * nebula_common. rearrange return types Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * mkdocs. update generation to match new repository structure Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Ament Bug. Component not installing binaries Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * hw_interface. do not fail when packet size is incorrect Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * hesai_status. PAndatAT128 support Dual only Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * at128 decoder. store the azimuth value Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * launch. add missing correction file param Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * cmake. fix velodyne missing export from nebula_common Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * return_type(VLP32) * hesai_hw_interface. reduce verbosity Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * docs. add/update mkdocs Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Load correction dat with resolution * at128. cleanup Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * nebula_monitor. cleanup Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * return_type of hesai * QT64 fix * nebula all. apply clang format Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * nebula_decoders. cleanup decoders Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * velodyne_decoders. cleanup Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * nebula_decoders. clang format Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * Mkdocs. add how to add sensor Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * IDENTICAL in QT128 * Changed ReturnType from velodyne_scan_decoder to nebula_common * code cleanup Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * wip. get calibration from sensor Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * get calib from sensor with callback * README. update return modes Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * cleanup. remove comments Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * clang. apply clang Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * add syncGetLidarCalibration * Remove livox_msgs Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * rename messages to nebula_messages Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * messages. rename to nebula_messages Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * add new point type Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * clang. apply Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Create nebula_sensor_driver metapackage Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Use local file if connect fails * apply clang format Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * out pcd only xyz * TEST using only a single PCD including only XYZ * test. update ci testing Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * clean up. angle dependencies Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * README. include new point type Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * github. ci. dont updgrade base image to accelerate build Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * decoders. remove type warnings Signed-off-by: amc-nu <abraham.monrroy@gmail.com> --------- Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> Signed-off-by: amc-nu <abraham.monrroy@gmail.com> Co-authored-by: Kyutoku <github@kyutoku.cloud>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
* replace AT128 pcd file for test * apply clang format Signed-off-by: amc-nu <abraham.monrroy@gmail.com> --------- Signed-off-by: amc-nu <abraham.monrroy@gmail.com> Co-authored-by: Kyutoku <github@kyutoku.cloud>
* Remove Boost warnings Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Optimize Pandar40P Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Pandar64 optimization Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * PointTypes. standardize point types Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Add radian based elevation calculation Pandar40P,64 Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * qt64. radian based coordinate calculation Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * xt32. radian based coordinate calculation Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * qt128. radian based coordinate calculation Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * qt128. radian based coordinate calculation Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * pandar40. precalculate sin/cos Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * pandarxt. precalculate te sin/cos Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * apply sin/cos optimization to all decoders Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> * launch. fix python launch file Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * point_type. caetr SSE alignment optimization Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * hesai_hw. remove warning Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * point_types. add sse description for caetr Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * README. run tests only for nebula packages Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * clang. apply ament_clang reformat Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Replace 40P, 64, QT64 and XT32s' PCD files to fix testing * remove clang-format from tests Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * Local path check not required for online acquisition * Adding timeouts to correction data acquisition * Disable calibration query Signed-off-by: amc-nu <abraham.monrroy@gmail.com> --------- Signed-off-by: amc-nu <abraham.monrroy@gmail.com> Signed-off-by: Abraham Cano <abrahammonrroy@yahoo.com> Co-authored-by: Kyutoku <github@kyutoku.cloud>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
* style(pre-commit): autofix * hesai_decoders. update timestamp calculation Signed-off-by: amc-nu <abraham.monrroy@gmail.com> * hesai_decoders. update azimuth Signed-off-by: amc-nu <abraham.monrroy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type