Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

refactor: rename acc topic #398

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jul 8, 2022

Signed-off-by: Takamasa Horibe horibe.takamasa@gmail.com

PR Type

  • Improvement

Related Links

autowarefoundation/autoware.universe#1213

Description

change for autowarefoundation/autoware.universe#1213

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe force-pushed the refactor/replace-acc-calculation-in-planning-control branch from 0d02b8f to d014bb1 Compare September 16, 2022 06:48
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 62578e4 into awf-latest Sep 17, 2022
@TakaHoribe TakaHoribe deleted the refactor/replace-acc-calculation-in-planning-control branch September 17, 2022 06:24
0x126 pushed a commit that referenced this pull request Sep 20, 2022
* refactor: rename acc topic

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* remove lpf_gain param

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants