Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix(trajectory_follower): change default param for curvature smoothing #236

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Mar 8, 2022

PR Type

  • Bug Fix

Related Links

None.

Description

The value 1 for this parameter causes a noisy steering command. Set default back to 15 as in the previous version.

Note that for the vehicle driving a narrow road with high tracking precision, please keep using 1 value.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested a review from tkimura4 March 8, 2022 10:56
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe merged commit 6c1c98e into tier4/universe Mar 8, 2022
@TakaHoribe TakaHoribe deleted the fix/mpc-default-param branch March 8, 2022 11:12
s-azumi pushed a commit to s-azumi/autoware_launch that referenced this pull request Apr 21, 2022
maxime-clem pushed a commit that referenced this pull request May 27, 2022
tier4-autoware-public-bot bot pushed a commit that referenced this pull request Mar 8, 2023
feat(behavior_path_planner): add config for pull out on new framework

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants