Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(imu_monitor): change yaw_rate_diff_threshold from 0.14 to 0.18 #582

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

TomohitoAndo
Copy link

@TomohitoAndo TomohitoAndo commented Jun 15, 2023

Description

Tuned yaw_rate_diff_threshold based on experimental data.
I modified this value in this PR before, but the threshold was not enough.

Related ticket
TIER IV INTERNAL LINK

Tests performed

Tested on an actual vehicle.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
@TomohitoAndo TomohitoAndo requested a review from 0x126 June 15, 2023 11:46
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.6.1@f93e66a). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##             beta/v0.6.1     #582   +/-   ##
==============================================
  Coverage               ?   10.58%           
==============================================
  Files                  ?     1249           
  Lines                  ?    90052           
  Branches               ?    20801           
==============================================
  Hits                   ?     9532           
  Misses                 ?    70433           
  Partials               ?    10087           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.56% <0.00%> (?) Carriedforward from b7d18ed

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@0x126 0x126 merged commit 281b6ed into beta/v0.6.1 Jun 15, 2023
@0x126 0x126 deleted the change-imu-monitor-threshold branch June 15, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants