Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sync upstream #486

Merged
merged 9 commits into from
May 17, 2023
Merged

chore: sync upstream #486

merged 9 commits into from
May 17, 2023

Conversation

tier4-autoware-public-bot[bot]
Copy link

Features

Bug Fixes

Code Refactoring

Tests

takayuki5168 and others added 9 commits May 16, 2023 11:17
…rom drivable area (autowarefoundation#3710)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…tion#3532)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…line (autowarefoundation#3720)

* fix(behavior_path_planner): keep terminal point in resamplePathWithSpline

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* refactoring

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…utowarefoundation#3695)

* test(planning_test_utils): add ASSART_NO_THROW_WITH_ERROR_MSG macro

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* update for behavior_velocity_planner

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

* fix for exception error msg

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

---------

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
* feat(behavior_path_planner): lane change abort

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

feat(behavior_path_planner): fix abort path generation

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

replace support strong typing in isLaneChangePathSafe

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

move is approved path

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

Move isEndOfLane

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

move lane change states to interface

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

style(pre-commit): autofix

rearrange base class

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

style(pre-commit): autofix

fix conflict

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

feat(behavior_path_planner): rebase and fix

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

feat(behavior_path_planner): add state transition functions

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

fix other module terminated due to lane change giving empty reference

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

fix current_state_ not being overwritten

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

feat(behavior_path_planner): new arch

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

fix(behavior_path_planner): solve conflicts

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): use old arch

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix safety check

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix updateState

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix get abort path

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix stop state transition

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): remove unnecessary functions

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): fix state transition if cancel condition is satisfied

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* Update planning/behavior_path_planner/src/scene_module/lane_change/normal.cpp

Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>

* style(pre-commit): autofix

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…goal_planner (autowarefoundation#3717)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…undation#3721)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
…tion#3722)

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…refoundation#3726)

fix(behavior_path_planner): add isInLaneletWithYawThreshold

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 7.48% and project coverage change: +1.22 🎉

Comparison is base (a971e75) 14.55% compared to head (14b183f) 15.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@              Coverage Diff               @@
##           tier4/main     #486      +/-   ##
==============================================
+ Coverage       14.55%   15.78%   +1.22%     
==============================================
  Files            1409      303    -1106     
  Lines           99298    29681   -69617     
  Branches        29378    15530   -13848     
==============================================
- Hits            14457     4684    -9773     
+ Misses          69258    19722   -49536     
+ Partials        15583     5275   -10308     
Flag Coverage Δ
differential 15.78% <7.48%> (?)
total ?
Impacted Files Coverage Δ
.../scene_module/goal_planner/goal_planner_module.hpp 60.00% <ø> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <0.00%> (+1.83%) ⬆️
...ath_planner/scene_module/lane_change/interface.hpp 50.00% <ø> (+16.66%) ⬆️
...r_path_planner/scene_module/lane_change/normal.hpp 100.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 19.72% <0.00%> (-0.05%) ⬇️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.86% <0.00%> (+0.04%) ⬆️
...planner/src/scene_module/lane_change/interface.cpp 14.39% <0.00%> (+0.79%) ⬆️
... and 37 more

... and 1127 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tier4-autoware-public-bot tier4-autoware-public-bot bot merged commit 0f8d423 into tier4/main May 17, 2023
@tier4-autoware-public-bot tier4-autoware-public-bot bot deleted the sync-upstream branch May 17, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation launch planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants