Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(default_adapi): subscribe planning factor #1734

Merged

Conversation

satoshi-ota
Copy link

Description

New factor msgs were defined in tier4/tier4_autoware_msgs#155 to output various information of module running state. And, each planning module will use them.

In this PR, I fixed adapi node to convert msg type from tier4_planning_msgs/PlanningFactorArray to autoware_adapi_v1_msgs/VelocityFactorArray(SteeringFactorArray).

Related links

Parent Issue:

How was this PR tested?

image

  1. launch psim.
  2. put ego and goal.
  3. put object on ego path.
  4. check the topic /api/planning/velocity_factors by echo command.
  5. confirm that the node outputs factor like following one.
header:
  stamp:
    sec: 1735008280
    nanosec: 610628888
  frame_id: map
factors:
- pose:
    position:
      x: 61578.199978951016
      y: 56213.78579257302
      z: 78.16299873101634
    orientation:
      x: -3.6191521078641166e-05
      y: -0.0006830251435586911
      z: -0.052912858993544
      w: 0.9985988992182779
  distance: 14.520707130432129
  status: 1
  behavior: route-obstacle
  sequence: ''
  detail: ''
  cooperation: []

Notes for reviewers

None.

Interface changes

Version Topic Type Topic Name Message Type Description
Old Sub /planing/planning_factors/xxx tier4_planning_msgs/PlanningFactorArray Topic description
New Sub /planing/velocity(steering)_factors/xxx autoware_adapi_v1_msgs/VelocityFactorArray(SteeringFactorArray) Topic description

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

github-actions bot commented Dec 24, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The velocity/steering factor has a status, but planning factor does not. The status of velocity factor will be automatically completed. However, the status of steering factor will not be assigned.

system/autoware_default_adapi/src/planning.hpp Outdated Show resolved Hide resolved
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota
Copy link
Author

The velocity/steering factor has a status, but planning factor does not. The status of velocity factor will be automatically completed. However, the status of steering factor will not be assigned.

Thanks for your comment. You're right.

I fixed logic in 5d55a4b to fill status automatically.

status: SteeringFactor::APPROACHING
Screenshot from 2024-12-25 09-26-08

status: SteeringFactor::TURNING
Screenshot from 2024-12-25 09-26-27

Copy link

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota merged commit 55ffc57 into feat/development-branch-planning-factor Dec 25, 2024
20 checks passed
@satoshi-ota satoshi-ota deleted the feat/adapi-planning-factor branch December 25, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants