-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): modules to support SDK 9.x.x and iOS 10 #12973
Conversation
Fixes TIMOB-28509
Tests:
|
@ewanharris , would you mind testing this PR out on your iPhone 5 please? Simplest thing to do is...
const map = require("ti.map");
const annotations = [];
annotations.push(map.createAnnotation({
userData: { type: "waypoint" },
bubbleParent: false,
title: "Hello World",
latitude: 51.507,
longitude: 0.128,
}));
const window = Ti.UI.createWindow();
const mapView = map.createView({ width: Ti.UI.FILL, height: Ti.UI.FILL });
mapView.addAnnotations(annotations);
window.add(mapView);
window.addEventListener("open", () => {
mapView.showAnnotations(annotations);
});
window.open(); For the other modules, maybe simply requiring them in will be enough to test loading their libraries? |
Another test for Hyperloop is to include a native module and attempt to utilize it <project>\Podfile
app.js const MTBBarcodeScanner = require('MTBBarcodeScanner/MTBBarcodeScanner'); Project should build correctly, should not see this error:
|
@ewanharris , @garymathews , regarding the hyperloop test, note that I updated the hyperloop module in PR #12905 (I combined it with my iOS LiveView fix). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR pass, able to load the following modules successfully on an iPhone 5 using 9.3.2.GA
- ti.coremotion
- ti.webdialog
- ti.identity
- ti.map
- urlSession
Note: I can't test that ti.applesignin loads on the iPhone 5 as it requires iOS 13+
JIRA:
https://jira.appcelerator.org/browse/TIMOB-28509
Summary: