-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): add LiveView support to Hyperloop #12905
Conversation
Fixes TIMOB-28461
Tests:
|
Fixes TIMOB-28508
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FR pass. Able to build to iPhone 5 using SDK 9.3.2 and hyperloop now, also liveview function as expected
FR Passed. |
The backport to
Check the run for full details # Fetch latest updates from GitHub
git fetch
# Check out the target branch
git checkout 10_0_X
# Make sure it's up to date
git pull
# Check out your branch
git checkout -b backport-12905-to-10_0_X
# Apply the commits from the PR
curl -s https://github.com/appcelerator/titanium_mobile/commit/a4964f3e4ab22fb9c732905ab23d5da10b23fe9b.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/4af59b866c8dad8e2cea218c99a823ed1a04844d.patch | git am -3 --ignore-whitespace
curl -s https://github.com/appcelerator/titanium_mobile/commit/36102ca16e4081fff7ec5fba2ec14b66b47bba53.patch | git am -3 --ignore-whitespace
# Push it to GitHub
git push --set-upstream origin backport-12905-to-10_0_X Then, create a pull request where the |
* hyperloop regression with encrypted builds * re-add 32-bit support for Titanium 9.x.x Fixes TIMOB-28461, TIMOB-28508
JIRA:
Summary:
hyperloop.bootstrap.js
providing bindings between native types to JS files.Note:
The following still won't work with LiveView because they require a native rebuild.
Hyperloop.defineClass()
calls. (Because it involves native code generation.)Test:
appc run -p ios --liveview
hyperloop-examples/app/controllers/ios/label.js
infoString
from'We ♥ iOS'
to'We ♥ LiveView'
and save.appc run -p ios -D test --liveview