Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): use supportedInterfaceOrientations of UINavigationController.topViewController instead of UINavigationController #12458

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

vijaysingh-axway
Copy link
Contributor

…r.topViewController instead of UINavigationController
@build build added this to the 9.3.2 milestone Feb 9, 2021
@build build requested a review from a team February 9, 2021 23:28
@build
Copy link
Contributor

build commented Feb 9, 2021

Fails
🚫 Tests have failed, see below for more information.
Warnings
⚠️

Commit 5cf784f7d2cb006ccae4a156a6d09a0b76ad38be has a message "fix(ios): use supportedInterfaceOrientations of UINavigationController.topViewController instead of UINavigationController" giving 1 errors:

  • header must not be longer than 100 characters, current length is 122
Messages
📖

💾 Here's the generated SDK zipfile.

📖

🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.

📖 ❌ 4 tests have failed There are 4 tests failing and 900 skipped out of 13695 total tests.

Tests:

ClassnameNameTimeError
ios.ipad.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)0.957
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:5764:29
ios.ipad.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.356
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@2x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/D5325D35-8512-4A56-BF9A-970E14891CB0/data/Containers/Bundle/Application/E1B0654E-DDED-4F2E-8F4C-3D1461FC2A89/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.ListViewAll text should show if ListView.style is .INSET_GROUPED (14.4)1.411
Error: expected 'Ti.UI.View' to match image ('snapshots/listview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti.ui.listview.test.js:1441:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:5764:29
ios.iphone.Titanium.UI.TableViewAll text should show if TableView.style is .INSET_GROUPED (14.4)0.425
Error: expected 'Ti.UI.View' to match image ('snapshots/tableview_style_inset_grouped_540x960@3x.png')
    mismatched pixels
fail@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/node_modules/should/cjs/should.js:275:23
value@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/node_modules/should/cjs/should.js:356:23
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti.ui.tableview.test.js:1793:28
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4376:41
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4763:17
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4840:23
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4688:20
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4698:15
next@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4636:30
file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:4665:13
timeslice@file:///Users/build/Library/Developer/CoreSimulator/Devices/9DBC9E91-42E9-4370-8363-2A753A1F1C19/data/Containers/Bundle/Application/5EC9450C-B03E-4B42-A2BD-49DF28496D59/mocha.app/ti-mocha.js:5764:29

Generated by 🚫 dangerJS against 5cf784f

@ssekhri
Copy link

ssekhri commented Feb 10, 2021

FR Passed

@sgtcoolguy sgtcoolguy merged commit 1f1127a into tidev:9_3_X Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants