fix(ios): use supportedInterfaceOrientations of UINavigationController.topViewController instead of UINavigationController

[vijaysingh-axway]

https://jira.appcelerator.org/browse/TIMOB-28282

[build]

	Fails
🚫	Tests have failed, see below for more information.

	Warnings
⚠️	Commit 39f1848d7133593173d579e1448a37441cf6c8d9 has a message "fix(ios): use supportedInterfaceOrientations of UINavigationController.topViewController instead of UINavigationController" giving 1 errors: header must not be longer than 100 characters, current length is 122

	Messages
📖	💾 Here's the generated SDK zipfile.
📖	🚨 This PR has one or more commits with warnings/errors for commit messages not matching our configuration. You may want to squash merge this PR and edit the message to match our conventions, or ask the original developer to modify their history.
📖	❌ 1 tests have failed There are 1 tests failing and 970 skipped out of 10977 total tests.

Tests:

Classname	Name	Time	Error
android.emulator.Titanium.Geolocation	#forwardGeocoder() (9)	1.87	Error: expected 37.3910366 to be approximately 37.387 ±0.004 at Assertion.fail (/node_modules/should/cjs/should.js:275:13) at Assertion.value [as approximately] (/node_modules/should/cjs/should.js:356:9) at Geolocation.<anonymous> (/ti.geolocation.test.js:316:26)

Generated by 🚫 dangerJS against f2518bf

[ssekhri]

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.2.3.v20201210165845
Appc CLI: 8.1.1
JDK: 11.0.6
Node: 12.16.1
Studio: 6.0.0.202005141803
Xcode: 12.0.1
iPhone 7Plus(v14.2)

[sgtcoolguy]

I do not know enough about this to give useful feedback. The code looks ok style-wise, but that's about all I can offer.

I think for a navigation controller, you're supposed to ask it's delegate for the supported orientations:

• https://developer.apple.com/documentation/uikit/uinavigationcontroller?language=objc
• https://developer.apple.com/documentation/uikit/uinavigationcontrollerdelegate/1621884-navigationcontrollersupportedint?language=objc

But I don't see us implementing the expected method for the delegate protocol in any classes we declare conforming to the protocol.