Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): setting TableView row layout to "horizontal" or "vertical" crashes #11809

Merged
merged 6 commits into from
Jul 14, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iphone/TitaniumKit/TitaniumKit/Sources/API/TiViewProxy.m
Original file line number Diff line number Diff line change
Expand Up @@ -1647,7 +1647,7 @@ - (void)makeViewPerformSelector:(SEL)selector withObject:(id)object createIfNeed
{
BOOL isAttached = [self viewAttached];

if (!isAttached && !create) {
if ((!isAttached && !create) || ![[self view] respondsToSelector:selector]) {
return;
}

Expand Down
59 changes: 59 additions & 0 deletions tests/Resources/ti.ui.tableview.addontest.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
/*
* Appcelerator Titanium Mobile
* Copyright (c) 2015-Present by Appcelerator, Inc. All Rights Reserved.
* Licensed under the terms of the Apache Public License
* Please see the LICENSE included with this distribution for details.
*/
/* eslint-env mocha */
/* eslint no-unused-expressions: "off" */
'use strict';
const should = require('./utilities/assertions');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ tests/Resources/ti.ui.tableview.addontest.js line 10 – 'should' is assigned a value but never used. (no-unused-vars)


describe('Titanium.UI.TableView', function () {
this.timeout(5000);

let win;
afterEach(done => { // fires after every test in sub-suites too...
if (win && !win.closed) {
win.addEventListener('close', function listener () {
win.removeEventListener('close', listener);
win = null;
done();
});
win.close();
} else {
win = null;
done();
}
});

it.ios('row with vertical layout', function (finish) {
var tableData = [];
for (var index = 1; index <= 20; index++) {
var row = Ti.UI.createTableViewRow({
layout: 'vertical'
});
row.add(Ti.UI.createLabel({ text: 'Row ' + index.toString() }));

tableData.push(row);
}
var table = Ti.UI.createTableView({
data: tableData
});
win = Ti.UI.createWindow();

function addTableView() {
try {
// After adding table, app should not crash
win.add(table);
finish();
} catch (err) {
finish(err);
}
}

win.addEventListener('postlayout', addTableView);
win.add(table);
vijaysingh-axway marked this conversation as resolved.
Show resolved Hide resolved
win.open();
});
});