-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ios): setting TableView row layout to "horizontal" or "vertical" crashes #11809
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
952bf8f
fix(ios): setting TableView row layout to "horizontal" or "vertical" …
vijaysingh-axway 8d09f16
test(ios): cleaned test case
vijaysingh-axway 8062ef8
fix(ios): setting TableView row layout to "horizontal" or "vertical" …
vijaysingh-axway ad9b6ed
style(ios): fixed linting issue
vijaysingh-axway 7259f7d
test(ios): added horizontal layout as well
vijaysingh-axway 17b7303
Merge branch 'master' into TIMOB-28001
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
/* | ||
* Appcelerator Titanium Mobile | ||
* Copyright (c) 2015-Present by Appcelerator, Inc. All Rights Reserved. | ||
* Licensed under the terms of the Apache Public License | ||
* Please see the LICENSE included with this distribution for details. | ||
*/ | ||
/* eslint-env mocha */ | ||
/* eslint no-unused-expressions: "off" */ | ||
'use strict'; | ||
const should = require('./utilities/assertions'); | ||
|
||
describe('Titanium.UI.TableView', function () { | ||
this.timeout(5000); | ||
|
||
let win; | ||
afterEach(done => { // fires after every test in sub-suites too... | ||
if (win && !win.closed) { | ||
win.addEventListener('close', function listener () { | ||
win.removeEventListener('close', listener); | ||
win = null; | ||
done(); | ||
}); | ||
win.close(); | ||
} else { | ||
win = null; | ||
done(); | ||
} | ||
}); | ||
|
||
it.ios('row with vertical layout', function (finish) { | ||
var tableData = []; | ||
for (var index = 1; index <= 20; index++) { | ||
var row = Ti.UI.createTableViewRow({ | ||
layout: 'vertical' | ||
}); | ||
row.add(Ti.UI.createLabel({ text: 'Row ' + index.toString() })); | ||
|
||
tableData.push(row); | ||
} | ||
var table = Ti.UI.createTableView({ | ||
data: tableData | ||
}); | ||
win = Ti.UI.createWindow(); | ||
|
||
function addTableView() { | ||
try { | ||
// After adding table, app should not crash | ||
win.add(table); | ||
finish(); | ||
} catch (err) { | ||
finish(err); | ||
} | ||
} | ||
|
||
win.addEventListener('postlayout', addTableView); | ||
win.add(table); | ||
vijaysingh-axway marked this conversation as resolved.
Show resolved
Hide resolved
|
||
win.open(); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.