Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): setting TableView row layout to "horizontal" or "vertical" crashes #11809

Merged
merged 6 commits into from
Jul 14, 2020

Conversation

vijaysingh-axway
Copy link
Contributor

@build build added this to the 9.1.0 milestone Jul 8, 2020
@build build requested a review from a team July 8, 2020 19:29
@build build added the ios label Jul 8, 2020
@build
Copy link
Contributor

build commented Jul 8, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6686 tests are passing.
(There are 698 skipped tests not included in that total)

Generated by 🚫 dangerJS against 7259f7d

/* eslint-env mocha */
/* eslint no-unused-expressions: "off" */
'use strict';
const should = require('./utilities/assertions');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ⚠️ tests/Resources/ti.ui.tableview.addontest.js line 10 – 'should' is assigned a value but never used. (no-unused-vars)

@sgtcoolguy sgtcoolguy self-requested a review July 13, 2020 18:22
@ssekhri
Copy link

ssekhri commented Jul 13, 2020

FR Passed.
Verified on:
Mac OS: 10.15.4
SDK: 9.1.0.v20200709124407
Appc CLI: 8.0.0
JDK: 11.0.6
Node: 10.17.0
Studio: 6.0.0.202005141803
Xcode: 12.0 beta
iOS simulator: 12.2, 13.5, 14.0 beta

@sgtcoolguy sgtcoolguy merged commit fd53a51 into tidev:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants