-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android)(9_0_X): add "google-services.json" support #11514
Conversation
|
@hansemannn with this PR firebase-auth works. |
Jep, thx! I really hope this makes it into 9.0.1. Can't update to 9.x before this. |
@hansemannn, @m1ga, are you unable to update your firebase modules until this change makes it in? |
@jquick-axway in my tests I can't use the latest versions of the modules because of I didn't try to update the other modules to the latest module versions yet since I have a setup now that works and I don't want to change it :) |
That's what I was afraid of. For your info, the google-services gradle tool turns the JSON into string xml entries under the "res" folder. So, it's failing to find these string resources. |
Yep, that was exactly our issue. We used a local fork that includes the patch now, so once this is merged, we can go official again! |
FR Passed |
JIRA: https://jira.appcelerator.org/browse/TIMOB-27745
Cherry-pick of PR: #11461