Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): add "google-services.json" support #11461

Merged
merged 14 commits into from
Apr 15, 2020

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Feb 4, 2020

JIRA:
https://jira.appcelerator.org/browse/TIMOB-27745

Test:

  1. Download the kitchensink-v2 app.
  2. Build and run on Android.
  3. Verify that the app builds and runs without issue.
  4. Download google-services.json. (Only Axway employees can access this.)
  5. Copy the google-services.json file to: ./app/platform/android
  6. Build and run on Android.
  7. In the log, verify that you see the following message.
[INFO]  [GRADLE] Parsing json file: /Users/<YourFolder>/kitchensink-v2/build/android/app/google-services.json

@build build added this to the 9.0.0 milestone Feb 4, 2020
@build
Copy link
Contributor

build commented Feb 4, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6659 tests are passing.
(There are 698 skipped tests not included in that total)

Generated by 🚫 dangerJS against 8ff2356

@jquick-axway
Copy link
Contributor

jquick-axway commented Feb 11, 2020

@hansemannn, can you add the below code to the top of our app.build.gradle template please? The idea is we want to automatically use the plugin if the google-services.json file exists since the plugin's main purpose is to read the file and turn it into "res" info. The below code should go just below our other apply plugin: '...' statement. Thanks!

if (file("${projectDir}/google-services.json").exists()) {
	apply plugin: 'com.google.gms.google-services'
}

Edit: Or I can finish up this PR's changes if you want.

@jquick-axway jquick-axway modified the milestones: 9.0.0, 9.0.1 Feb 11, 2020
@hansemannn
Copy link
Collaborator Author

@jquick-axway Added it!

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@jquick-axway jquick-axway changed the title chore(android): handle google-services.json feat(android): add "google-services.json" support Mar 3, 2020
@sgtcoolguy sgtcoolguy modified the milestones: 9.0.1, 9.1.0 Apr 3, 2020
@ssekhri
Copy link

ssekhri commented Apr 15, 2020

FR Passed
Mac OS: 10.15.4
SDK: 9.1.0.v20200413130540
Appc CLI: 8.0.0
JDK: 11.0.4
Node: 10.17.0
Studio: 6.0.0.202003181504
Device: Pixel3(v10.0) emulator

@ssekhri ssekhri merged commit d04d9e9 into tidev:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants