Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary Queue Prometheus Metrics #804

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions data/service/api/v1/v1.go
Original file line number Diff line number Diff line change
@@ -1,10 +1,25 @@
package v1

import (
"net/http"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promhttp"

"github.com/tidepool-org/platform/data/service"
dataService "github.com/tidepool-org/platform/data/service"
"github.com/tidepool-org/platform/service/api"
)

func PrometheusMetrics(dataServiceContext dataService.Context) {
res := dataServiceContext.Response()
req := dataServiceContext.Request()

// The default go-json-rest middleware gzips the content
promhttp.HandlerFor(prometheus.DefaultGatherer, promhttp.HandlerOpts{DisableCompression: true}).
ServeHTTP(res.(http.ResponseWriter), req.Request)
}

func Routes() []service.Route {
routes := []service.Route{
service.Post("/v1/datasets/:dataSetId/data", DataSetsDataCreate, api.RequireAuth),
Expand All @@ -20,6 +35,7 @@ func Routes() []service.Route {
service.Put("/v1/data_sets/:dataSetId", DataSetsUpdate, api.RequireAuth),
service.Get("/v1/time", TimeGet),
service.Post("/v1/users/:userId/data_sets", UsersDataSetsCreate, api.RequireAuth),
service.Get("/v1/metrics", PrometheusMetrics),
}

routes = append(routes, DataSetsRoutes()...)
Expand Down
36 changes: 34 additions & 2 deletions data/summary/store/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ import (
"fmt"
"time"

"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/promauto"

"go.mongodb.org/mongo-driver/bson"
"go.mongodb.org/mongo-driver/mongo"
"go.mongodb.org/mongo-driver/mongo/options"
Expand All @@ -15,6 +18,18 @@ import (
storeStructuredMongo "github.com/tidepool-org/platform/store/structured/mongo"
)

var (
QueueLag = promauto.NewHistogramVec(prometheus.HistogramOpts{
Roukoswarf marked this conversation as resolved.
Show resolved Hide resolved
Name: "tidepool_summary_queue_lag",
Help: "The current queue lag in seconds",
Buckets: []float64{0.5, 1, 2.5, 5, 7.5, 10, 25, 50, 75, 100, 150, 250, 500, 1000},
}, []string{"type"})
QueueLength = promauto.NewGaugeVec(prometheus.GaugeOpts{
Name: "tidepool_summary_queue_length",
Help: "The current queue length in number of summaries",
}, []string{"type"})
)

type Repo[A types.StatsPt[T], T types.Stats] struct {
*storeStructuredMongo.Repository
}
Expand Down Expand Up @@ -213,6 +228,14 @@ func (r *Repo[A, T]) SetOutdated(ctx context.Context, userId, reason string) (*t
return userSummary.Dates.OutdatedSince, nil
}

func (r *Repo[T, A]) GetSummaryQueueLength(ctx context.Context) (int64, error) {
selector := bson.M{
"type": types.GetTypeString[T, A](),
"dates.outdatedSince": bson.M{"$lte": time.Now().UTC()},
}
return r.CountDocuments(ctx, selector)
}

func (r *Repo[T, A]) GetOutdatedUserIDs(ctx context.Context, page *page.Pagination) (*types.OutdatedSummariesResponse, error) {
if ctx == nil {
return nil, errors.New("context is missing")
Expand All @@ -221,8 +244,10 @@ func (r *Repo[T, A]) GetOutdatedUserIDs(ctx context.Context, page *page.Paginati
return nil, errors.New("pagination is missing")
}

typ := types.GetTypeString[T, A]()

selector := bson.M{
"type": types.GetTypeString[T, A](),
"type": typ,
"dates.outdatedSince": bson.M{"$lte": time.Now().UTC()},
}

Expand All @@ -231,7 +256,7 @@ func (r *Repo[T, A]) GetOutdatedUserIDs(ctx context.Context, page *page.Paginati
{Key: "dates.outdatedSince", Value: 1},
})
opts.SetLimit(int64(page.Size))
opts.SetProjection(bson.M{"stats": 0})
opts.SetProjection(bson.M{"userId": 1, "dates": 1})

cursor, err := r.Find(ctx, selector, opts)
if err != nil {
Expand Down Expand Up @@ -260,6 +285,13 @@ func (r *Repo[T, A]) GetOutdatedUserIDs(ctx context.Context, page *page.Paginati
response.End = *userSummary.Dates.OutdatedSince
}

QueueLag.WithLabelValues(typ).Observe(time.Now().UTC().Sub(response.Start).Seconds())
count, err := r.GetSummaryQueueLength(ctx)
if err != nil {
return nil, fmt.Errorf("unable to get summary queue length: %w", err)
}
QueueLength.WithLabelValues(typ).Set(float64(count))

return response, nil
}

Expand Down