Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary Queue Prometheus Metrics #804

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Roukoswarf
Copy link
Contributor

@Roukoswarf Roukoswarf commented Jan 13, 2025

This PR adds metrics to track summary queue lag and length via prometheus metrics.

data/summary/store/store.go Outdated Show resolved Hide resolved
data/summary/store/store.go Show resolved Hide resolved
Copy link
Contributor

@toddkazakov toddkazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidentally approved in my previous review. Left few comments.

Copy link
Contributor

@toddkazakov toddkazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to expose the metrics endpoint in the data service similar to how it's done in the task service https://github.com/tidepool-org/platform/blob/master/task/service/api/v1/v1.go#L40-L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants