Fix: Zod instanceof not working in lib #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://www.notion.so/Fix-instanceof-on-zod-9c21631b782043fdb67a42e8263a40dc?pvs=4
This is the added code to
ZodType
(there is no syntax highlighting on the GitHub diff):The idea is to overwrite the
instanceof
operator onZodType
(allzod
classes inherit it) code to check class names instead of constructor references (which are different whents-mongo
is used as a library).We could submit this fix to
zod
but it seems PRs there take a while to reach production.This PR was tested locally by importing it from the app using a dependency link.