fix: improper bindings of arguments #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Dec 10, 2018
|
Looks like all use it as transitive dep of |
|
No problem. I can work on that this week at spare time. |
|
That would be lovely! In the meantime I released a new patch release |
thymikee
pushed a commit
to thymikee/jest-preset-angular
that referenced
this pull request
Dec 13, 2018
This PR is addressed to thymikee/jest-zone-patch#9 (comment). For the sake of complete git history, I merge the commits into this repository. There is another LICENSE issue: The `jest-zone-patch` is licensed under BSD-3-Clause while this repository under MIT. I keep the original BSD LICENSE on this PR and left it as-is.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arrow function has no bindings of
argumentsobject. I doubt if it has ever been working properly.Fixed thymikee/jest-preset-angular#169 (comment)
I suggest we add some integration test (is that why the version is dangerously 0.0.x?) to prove the snippet works as intended.