Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Improve docs #258

Merged
merged 4 commits into from
Apr 7, 2019
Merged

📝 Improve docs #258

merged 4 commits into from
Apr 7, 2019

Conversation

krokofant
Copy link
Contributor

@krokofant krokofant commented Apr 7, 2019 •
edited
Loading

  • jest-zone-patch is embeded (Import jest zone patch #214) as a dependency and should not be mentioned as being installed at the same time as this package is not found in package.json, package-lock.json or yarn.lock - and can be presumed missing.
  • @types/jest might not be installed so install it explicitly
  • Specify how to avoid karma conflicts (ref chore: bump deps to get rid of some security warnings; unbreak master #233)
    • Otherwise consumers might get TypeError: Cannot read property 'prototype' of undefined while jest processes new angular cli projects

thymikee
thymikee approved these changes Apr 7, 2019
View reviewed changes
Copy link
Owner

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

README.md Show resolved Hide resolved
@thymikee thymikee merged commit 3b88d0c into thymikee:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krokofant @thymikee