Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump deps to get rid of some security warnings; unbreak master #233

Merged
merged 2 commits into from
Mar 4, 2019

Conversation

thymikee
Copy link
Owner

@thymikee thymikee commented Mar 4, 2019

Bumping deps. Also renamed test.ts to karmaTest.ts as this is what it is, and test.ts is caught by default testMatch of Jest

@thymikee thymikee changed the title chore: bump deps to get rid of some security warnings chore: bump deps to get rid of some security warnings; unbreak master Mar 4, 2019
@thymikee thymikee merged commit 1d37059 into master Mar 4, 2019
@thymikee thymikee deleted the chore/bump-deps branch March 4, 2019 17:55
@ahnpnl ahnpnl added this to the 7.0.0 milestone Mar 5, 2019
@krokofant krokofant mentioned this pull request Apr 7, 2019
thymikee pushed a commit that referenced this pull request Apr 7, 2019
* jest-zone-patch is embeded (#214) as a dependency and should not be mentioned as being installed at the same time as this package is not found in package.json, package-lock.json or yarn.lock - and can be presumed missing.
* @types/jest might not be installed so install it explicitly
* Specify how to avoid karma conflicts (ref #233)
  - Otherwise consumers might get `TypeError: Cannot read property 'prototype' of undefined` while jest processes new angular cli projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants