-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CI config to CircleCI v2 #212
Conversation
.circleci/config.yml
Outdated
command: | | ||
yarn test:ci | ||
- run: | ||
name: Test Example App |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two (test example and library) can go into workflows. I like to use this as a reference: https://github.com/callstack/react-native-paper/blob/master/.circleci/config.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, had them first put it in one step, but I preferred the immediate overview in the circleci-panel, in which part of the app the tests would fail. See this example
If you prefer them to be summarized, I can reduce them to one step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh now I got you, overlooked workflows
Will set that up 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so I made it work.
The overview is more extendable and tests run parallel, but currentlly we lose about 30s for not running in one workspace (workspace has to be persisted and attached between different jobs).
I still prefer it, as it gives a better overview, especially if we might later choose to add linting, generating docs, ... (see workflow example from react-native-paper)
CircleCI has to be configured differently for this repo itself to run the tests, I hoped it would auto-detect the config and the version. This means open PRs will have to include this config as well or they will not run the tests anymore after CircleCI was configured to use v2 for this repo. |
I've pointed it to |
* Moved example dependency installation in test-example * Added caching for test dependencies * Picked shorter names for jobs * Updated executor to use node:11
* origin/master: Upgraded ts-jest version. (#219) docs: add astTransformers in configuration example (#218) feat: Import jest-zone-patch (#214) chore: Migrate CI config to CircleCI v2 (#212) Transform templateUrl, styleUrls and styles everywhere (#211) feat: adjust semver range of jest-zone-patch (#209) Adjust CHANGELOG (#208)
CircleCI v1 is no longer supported and will stop working at all after August
Read more at circleci.com/sunset1-0
This PR contains the new config. It runs inside a node docker image instead of a fully fledged EC2 instance - so it is faster to setup and has yarn preinstalled.