Transform templateUrl, styleUrls and styles everywhere #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
templateUrl can also occur e. g. in tests, outside of decorators. These should also be transformed.
|
Note that I added |
wtho
changed the title
wtho
commented
Dec 6, 2018
thymikee
approved these changes
Dec 6, 2018
|
Lgtm 👍 |
ahnpnl
approved these changes
Dec 6, 2018
thymikee
pushed a commit
that referenced
this pull request
Dec 6, 2018
* Fix transformer to handle templateUrl everywhere templateUrl can also occur e. g. in tests, outside of decorators. These should also be transformed. * Update readme - preprocessor => transformer * Make comments match new implementation * Update comments and docs
thymikee
added a commit
that referenced
this pull request
Jan 26, 2019
* origin/master: Upgraded ts-jest version. (#219) docs: add astTransformers in configuration example (#218) feat: Import jest-zone-patch (#214) chore: Migrate CI config to CircleCI v2 (#212) Transform templateUrl, styleUrls and styles everywhere (#211) feat: adjust semver range of jest-zone-patch (#209) Adjust CHANGELOG (#208)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #210
templateUrlgets transformed e. g. in*.spec.tsoutside a decoratorREADME.md❗ Note that it seems the transformer was modified a lot, but basically I just removed code that only looked deep inside decorators. Now it checks everywhere for
stlyes,styleUrlsandtemplateUrl.