Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support angular v15 #1838 #1840

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 22, 2022

Summary

Angular 15 is not currently supported and throws invalid peer deps when used in an Angular 15 repo.

Test plan

Ran yarn build, yarn test and yarn test-examples

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

cc @ahnpnl Let me know if I've missed anything!

Fixes: #1838

@Coly010 Coly010 changed the title feat: support angular v15 #1833 feat: support angular v15 #1838 Nov 22, 2022
@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 23, 2022

I think you need to run yarn dedupe to fix the problem.

@Coly010 Coly010 force-pushed the 1833-support-angular-15 branch from 09b7aca to 325bee8 Compare November 23, 2022 12:42
@Coly010
Copy link
Contributor Author

Coly010 commented Nov 23, 2022

@ahnpnl Pushed update :)

@luizhp
Copy link

luizhp commented Nov 23, 2022

@ahnpnl Pushed update :)

thanks a lot. so, what's happen now? which steps are needed to release?

@ahnpnl ahnpnl merged commit c629535 into thymikee:main Nov 23, 2022
@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 23, 2022

Thanks!

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 23, 2022

@ahnpnl Pushed update :)

thanks a lot. so, what's happen now? which steps are needed to release?

Still work left is to adapt to Jest 29, see #1774 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 15 Support
3 participants