-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: npm install fails with latest jest 29.0.3 #1774
Comments
We haven’t finished supporting Jest 29 yet so ye this will have to wait for a major release. |
Any updates/guesses on when 29 will be supported? Thank you :) |
Anything yet? It's been 2 weeks. Can you give an estimate please? At least we can plan things better on our end. Thanks |
We downgraded Jest to version 28 and managed to get project working. |
Well, yeah, my project already works fine with Jest 28. We just wanted to keep up with Jest as it moves forward. I guess we'll wait until this is issue resolved and 29 is supported. |
Are there any plans to cut new release any time soon? It seems new version of Jest was merged to main branch and it passed CI just fine: #1804 There is a chain of changes that increases the importance of having
|
Hey guys, |
It will be together with angular 15 support in a major version:) |
|
Do you have a working branch we can test with current RC version of Angular 15? |
You can test against The leftover work now includes:
|
Whats interesting about this error: |
@christrude you're not looking at the state of the file when the |
you are right, i am a dumb dumb. |
I'd like to pose a question. Would it not make more sense to push a tag that supports Angular 15 and then deal with all of the breaking updates for Jest v29. At the moment anyone that updates via Nx to migrate to Angular 15 ( or without ) is getting blocked by what is effectively a single line package.json change related to peer dependencies. |
12.2.3 supports Angular 15:) |
Releasing on a holiday like a complete boss :) |
Any help needed on this ? :) Never contributed to this project but I'm willing to help if necessary, but I dont find what's left to do, sorry ! 😄 |
Any updates on this? |
Happy new year! Hope we can get back to solving this issue. It's holding up any real angular 15 release on our side. |
Why, if 12.2.3 supports Angular 15? |
Yes, sorry, I mean angular with Jest 29. Jest 28 + angular 15 is working. We usually release with latest jest, or try to at lease. |
|
Are these things the community can help with? Is it a block like there is no solution you can see or that there isn't time to make the changes? It's been taking a long time so I wanted to see what we can help with. |
Yes feel free to tackle these. |
Might be worth asking Nrwl to take over maintenance. It's a pretty sad state of things that we massively have to hold back this Jest upgrade because of one dependency that's not maintained. Even more so in workspaces that don't use Angular. |
You could always pitch in and help out... Complaining like that, just to complain, isn't helpful. ahnpnl's done an amazing job maintaining this project. They're very responsive and jumps on stuff quickly, when needed. We're just on the other side of a long holiday; why not give them the space to make the change, or pitch in and help out yourself. This is open source after all. |
People offered to help for months with no result. I'm trying to come up with a real solution instead of your utopian scenario. Already talking to Nrwl as we speak. |
What changes from |
That’s the only change which produces warning logs when running tests in |
Hi @ahnpnl I've been testing the v13.0.0-next.1 package on a handful of Nx repos without any issues. Was wondering if there is an ETA on a stable release for jest-preset-angular v13. |
Hi, I’m glad to hear that. I will arrange asap. |
Note that the documentation to migrate |
Version
2.2.2
Steps to reproduce
1,Use jest 29.0.3 as dependency with latest jest-preset-angular 2.2.2
2, npm install fails ERESOLVE unable to resolve dependency tree
Expected behavior
npm install works
Actual behavior
npm install
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: xxx@3.0.1
npm ERR! Found: jest@29.0.3
npm ERR! node_modules/jest
npm ERR! dev jest@"29.0.3" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer jest@"^28.0.0" from jest-preset-angular@12.2.2
npm ERR! node_modules/jest-preset-angular
npm ERR! dev jest-preset-angular@"12.2.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
Additional context
Would you release jest-angular-preset with jest 29 supported?
Environment
The text was updated successfully, but these errors were encountered: