Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@angular/cli): add support for Node.js version 18 #24026

Merged
merged 1 commit into from
Oct 7, 2022
Merged

feat(@angular/cli): add support for Node.js version 18 #24026

merged 1 commit into from
Oct 7, 2022

Conversation

alan-agius4
Copy link
Collaborator

Pacote version 14 does requires 14.17.x or 16.13.x.

BREAKING CHANGE: The Angular CLI no longer supports 16.10.x, 16.11.x and 16.12.x. Current supported versions of Node.js are 14.20.x, 16.13.x and 18.10.x.

@alan-agius4
feat(@angular/cli): add support for Node.js version 18
dbf03bb 
Pacote version 14 does requires `14.17.x` or `16.13.x`.

BREAKING CHANGE: The Angular CLI  no longer supports `16.10.x`, `16.11.x` and `16.12.x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
@angular-robot angular-robot bot added flag: breaking change feature Issue that requests a new feature labels Oct 6, 2022
@alfaproject
Copy link

Oh man, there's a huge problem with Jest for node 16.11+ so this means we won't be able to upgrade any time soon ):

Context: jestjs/jest#11956

@alan-agius4 alan-agius4 requested a review from clydin October 6, 2022 13:29
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 6, 2022
@alan-agius4
Copy link
Collaborator Author

Going through the issue and linked issues in the Node.js repo nodejs/node#44211 and nodejs/node#42080 it doesn't seem like it's something that is being tacked by the Node.js.

@alfaproject
Copy link

Yes, exactly. It's been a bit of a mess for months and we haven't been able to update to higher versions of node yet. I guess if the worst comes to worst we will just have to pay for xtra xtra xtra large CI runners. I was kind of hoping that we could stay another year on 16.10 if none of our dependencies had the need to update but it looks like that won't happen, meh

@alan-agius4 alan-agius4 added this to the v15 Feature Freeze milestone Oct 7, 2022
clydin
clydin approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@clydin clydin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jest situation is unfortunate. However, Node.js 16.10 is over a year old now and 16.13 is technically the first v16 LTS release. More and more packages will start using newer APIs and this will most likely accelerate once Node.js v14 is EOL in several months.
From reading through the linked Jest issue, there does appear to be several PRs with workarounds to some of the problems being encountered. Hopefully a new release of Jest can mitigate the issue.
@alfaproject Thank you for bringing up the Jest issue. The team will continue to monitor the issue and potentially evaluate if anything can be done to help mitigate the issue.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 7, 2022
@clydin clydin merged commit 4827d1b into angular:main Oct 7, 2022
@alan-agius4 alan-agius4 deleted the node.js branch October 7, 2022 15:36
@alan-agius4 alan-agius4 mentioned this pull request Oct 11, 2022
Closed
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Oct 11, 2022
@alan-agius4
feat(core): add support for Node.js version 19
f76dcd2 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are 14.20.x, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Oct 11, 2022
@alan-agius4
feat(core): add support for Node.js version 19
dfb4767 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports 14.[15-19].x and 16.[10-12].x. Current supported versions of Node.js are 14.20.x, 16.13.x and 18.10.x.
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Oct 11, 2022
@alan-agius4
feat(core): add support for Node.js version 19
f42e9e6 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Oct 11, 2022
@alan-agius4
feat(core): add support for Node.js version 19
c1f6177 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/angular that referenced this pull request Oct 11, 2022
@alan-agius4
feat(core): add support for Node.js version 18
52ffb47 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/universal that referenced this pull request Oct 11, 2022
@alan-agius4
feat(@nguniversal/common): add support for Node.js version 18
a8cab92 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/universal that referenced this pull request Oct 11, 2022
@alan-agius4
feat(@nguniversal/common): add support for Node.js version 18
70ff718 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular universal no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to ng-packagr/ng-packagr that referenced this pull request Oct 11, 2022
@alan-agius4
feat: add support for Node.js version 18
e70e3a3 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: ng-packagr no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to alan-agius4/universal that referenced this pull request Oct 11, 2022
@alan-agius4
feat(@nguniversal/common): add support for Node.js version 18
fbefdd5 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular universal no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
alan-agius4 added a commit to angular/universal that referenced this pull request Oct 11, 2022
@alan-agius4
feat(@nguniversal/common): add support for Node.js version 18
78cf7b7 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular universal no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.
jessicajaniuk pushed a commit to angular/angular that referenced this pull request Oct 11, 2022
@alan-agius4 @thePunderWoman
feat(core): add support for Node.js version 18 (#47730)
1b9fd46 
This change aligns with the supported Node.js versions of the Angular CLI.
See: angular/angular-cli#24026

BREAKING CHANGE: Angular no longer supports Node.js versions `14.[15-19].x` and `16.[10-12].x`. Current supported versions of Node.js are `14.20.x`, `16.13.x` and `18.10.x`.

PR Close #47730
This was referenced Oct 13, 2022
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker feature Issue that requests a new feature flag: breaking change
Projects
None yet
Milestone
v15 Feature Freeze
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @alfaproject @clydin