Add drawer unified folder support #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change implementation accordingly
wmontwe
force-pushed
the
add-drawer-unified-folder-support
branch
from
ca09738 to
b5d9a7d
Compare
cketti
approved these changes
Sep 23, 2024
| @@ -0,0 +1,8 @@ | |||
| package app.k9mail.feature.navigation.drawer.domain.entity | |||
|
|
|||
| data class DisplayUnifiedFolder( | |||
There was a problem hiding this comment.
Side note: This feels like you're trying to prepare for a future with more unified folders before we've decided on what that should actually look like (both from a UI/UX and code architecture perspective).
A simpler approach, that only models what's currently possible, probably would have been better. E.g.
data class DisplayUnifiedInboxFolder(
override val unreadMessageCount: Int,
override val starredMessageCount: Int,
) : DisplayFolder {
override val id: String = "unified_inbox"
}There was a problem hiding this comment.
I know, but I tested how much effort it would be to add more folders and it didn't seem too complicated. Disclaimer if I understood the search query correctly.
...tion/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/ui/folder/FolderListItem.kt
Show resolved
Hide resolved
...tion/drawer/src/main/kotlin/app/k9mail/feature/navigation/drawer/ui/folder/FolderListItem.kt
Outdated
Show resolved
Hide resolved
wmontwe
force-pushed
the
add-drawer-unified-folder-support
branch
from
b5d9a7d to
2375115
Compare
…trieve the display name
wmontwe
force-pushed
the
add-drawer-unified-folder-support
branch
from
2375115 to
d8d8868
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the unified folder support for the drawer. The default selection has not been implemented as it requires state information from the MessageList properly propagated: #8142
Depends on #8151
Resolves #8121