Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account and folder selection #8142

Closed
wmontwe opened this issue Sep 16, 2024 · 1 comment · Fixed by #8176
Closed

Fix account and folder selection #8142

wmontwe opened this issue Sep 16, 2024 · 1 comment · Fixed by #8176
Assignees
Labels
tb-team Tasks and features handled by project maintainers

Comments

@wmontwe
Copy link
Member

wmontwe commented Sep 16, 2024

The exsiting drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to introduce a separate view model to keep track of the currently active account and when needed selected folder. It should be bound to the lifecycle of the MessageList activity and exposed to the navigation drawer as single source of truth.

@wmontwe wmontwe self-assigned this Sep 16, 2024
@wmontwe wmontwe added the tb-team Tasks and features handled by project maintainers label Sep 17, 2024
@wmontwe wmontwe changed the title Add ViewModel to host current account selection Fix account and folder selection Sep 26, 2024
@wmontwe
Copy link
Member Author

wmontwe commented Sep 27, 2024

Update: The view model approach caused a couple of lifecycle issues and a mutable state is used solely for the new drawer implementation. To avoid rewriting the MessageList, it will remain responsible to set the desired states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tb-team Tasks and features handled by project maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant