Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Material 3 drawer #8100

Open
wmontwe opened this issue Sep 3, 2024 · 3 comments
Open

[EPIC] Material 3 drawer #8100

wmontwe opened this issue Sep 3, 2024 · 3 comments
Assignees
Labels
tb-team Tasks and features handled by project maintainers type: epic A major feature or initiative

Comments

@wmontwe
Copy link
Member

wmontwe commented Sep 3, 2024

The navigation drawer should look and feel consistent with the rest of the K-9 Mail and Thunderbird for Android Material 3 theme.
As the existing drawer is based on MaterialDrawer it has limited Material 3 support and doesn't allow us to easily adapt to the new design. Therefore we will rewrite the navigation drawer from scratch using Jetpack Compose.

Tasks:

To improve on:

Related bugs:

@wmontwe wmontwe added tb-team Tasks and features handled by project maintainers type: epic A major feature or initiative labels Sep 3, 2024
@wmontwe wmontwe self-assigned this Sep 3, 2024
@wmontwe
Copy link
Member Author

wmontwe commented Sep 16, 2024

The existing drawer has a complex setup to communicate account and folder changes between itself, the MessageList, MessageFragment and different entry points (widgets, notifications). To simplify the communication flow we decided to introduce a separate view model to keep track of the currently active account and when needed selected folder. It should be bound to the lifecycle of the MessageList activity and exposed to the navigation drawer as single source of truth -> #8142

This caused a couple of lifecycle issues and the MessageList remains responsible for the account and folder states.

@kewisch
Copy link
Member

kewisch commented Nov 19, 2024

@marcRDZ You were asking if you could support on any other issues related to the drawer. @wmontwe is working on some of the foundations for future support of account pictures, once he is done with that there would be an opportunity to help on the image picker.

There are a few remaining issues left on this epic, are there any that are interesting to you? We might not have linked all the issues after the fact, so good to check functionality as well.

@marcRDZ
Copy link
Contributor

marcRDZ commented Nov 19, 2024

@kewisch count on it, I'll review the list to check possible candidates to tackle asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tb-team Tasks and features handled by project maintainers type: epic A major feature or initiative
Projects
None yet
Development

No branches or pull requests

3 participants