Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffergeometryutils deprecations #396

Merged
merged 4 commits into from
Apr 25, 2023
Merged

Add buffergeometryutils deprecations #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49e4248
mark deprecated functions in `BufferGeometryUtils`
Apr 4, 2023
a92eb60
Add Mik-pe to list of contributors
Apr 4, 2023
6c9cbe9
Merge branch 'dev' into add-buffergeometryutils-deprecations
Methuselah96 Apr 25, 2023
2e05341
Update .all-contributorsrc
Methuselah96 Apr 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,15 @@
"code",
"bug"
]
},
{
"login": "Mik-pe",
"name": "Mikael Pettersson",
"avatar_url": "https://avatars.githubusercontent.com/u/5653426?v=4",
"profile": "https://github.com/Mik-pe",
"contributions": [
"code"
]
}
],
"skipCi": true,
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<td align="center" valign="top" width="14.28%"><a href="https://github.com/HEOJUNFO"><img src="https://avatars.githubusercontent.com/u/100739943?v=4?s=100" width="100px;" alt="HEOJUNFO"/><br /><sub><b>HEOJUNFO</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=HEOJUNFO" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="http://www.oletus.fi/"><img src="https://avatars.githubusercontent.com/u/453050?v=4?s=100" width="100px;" alt="Olli Etuaho"/><br /><sub><b>Olli Etuaho</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=Oletus" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/oetherington"><img src="https://avatars.githubusercontent.com/u/5075628?v=4?s=100" width="100px;" alt="Ollie Etherington"/><br /><sub><b>Ollie Etherington</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=oetherington" title="Code">💻</a> <a href="https://github.com/three-types/three-ts-types/issues?q=author%3Aoetherington" title="Bug reports">🐛</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://github.com/Mik-pe"><img src="https://avatars.githubusercontent.com/u/5653426?v=4?s=100" width="100px;" alt="Mikael Pettersson"/><br /><sub><b>Mikael Pettersson</b></sub></a><br /><a href="https://github.com/three-types/three-ts-types/commits?author=Mik-pe" title="Code">💻</a></td>
</tr>
</tbody>
</table>
Expand Down
14 changes: 12 additions & 2 deletions types/three/examples/jsm/utils/BufferGeometryUtils.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
} from '../../../src/Three';

export function deepCloneAttribute(attribute: BufferAttribute): BufferAttribute;
export function mergeBufferGeometries(geometries: BufferGeometry[], useGroups?: boolean): BufferGeometry;
export function mergeBufferAttributes(attributes: BufferAttribute[]): BufferAttribute;
export function mergeGeometries(geometries: BufferGeometry[], useGroups?: boolean): BufferGeometry;
export function mergeAttributes(attributes: BufferAttribute[]): BufferAttribute;
export function interleaveAttributes(attributes: BufferAttribute[]): InterleavedBufferAttribute;
export function estimateBytesUsed(geometry: BufferGeometry): number;
export function mergeVertices(geometry: BufferGeometry, tolerance?: number): BufferGeometry;
Expand All @@ -34,3 +34,13 @@ export function deinterleaveGeometry(geometry: BufferGeometry): void;
* @param creaseAngle The crease angle.
*/
export function toCreasedNormals(geometry: BufferGeometry, creaseAngle?: number): BufferGeometry;

/**
* @deprecated Use mergeGeometries instead.
*/
export function mergeBufferGeometries(geometries: BufferGeometry[], useGroups?: boolean): BufferGeometry;

/**
* @deprecated Use mergeAttributes instead.
*/
export function mergeBufferAttributes(attributes: BufferAttribute[]): BufferAttribute;